feat: Offline #10
Merged
feat: Offline #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adigidh
reviewed
Jul 10, 2024
docs/front-end/offline.md
Outdated
|
|
||
| This will allow a web application developer to store the html, css, and js files into a cache in the browser, which can then be loaded from the Service Worker. | ||
|
|
||
| Unrealted to offline, but they will also allow access to push notifications for the web. |
There was a problem hiding this comment.
*unrelated spelled incorrectly
adigidh
reviewed
Jul 10, 2024
docs/front-end/offline.md
Outdated
| @@ -0,0 +1,66 @@ | |||
| # Offline | |||
|
|
|||
| Offline could mean mulitple things in the context of Web Applications and it is important to be prepared for those different scenarios. | |||
There was a problem hiding this comment.
*multiple spelled incorrectly.
adigidh
reviewed
Jul 10, 2024
adigidh
reviewed
Jul 10, 2024
adigidh
reviewed
Jul 10, 2024
| Both approaches have a similar concept of getting something to the user quickly while the rest is being loaded in the background. | ||
|
|
||
| ### The Cache | ||
|
|
There was a problem hiding this comment.
do you think it's useful to add
- Precaching
- Serving requests from the cache
Or possibly add a link to the Service Worker lifecycle docs.
|
nice updates, couple of minor spelling mistakes. Some discussion points as comments. Overall LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the first draft of the offline section